Attachment 109488 Details for Bug 234484 – Adds code that explicitly removes the DW from the layout

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Adds code that explicitly removes the DW from the layout

patch(234484) (text/plain), 2.06 KB, created by Eric Moffatt

on 2008-08-07 22:09:35 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Moffatt

Created: 2008-08-07 22:09:35 EDT

Size: 2.06 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/PerspectiveHelper.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PerspectiveHelper.java,v
>retrieving revision 1.47
>diff -u -r1.47 PerspectiveHelper.java
>--- Eclipse UI/org/eclipse/ui/internal/PerspectiveHelper.java	23 Apr 2008 16:37:11 -0000	1.47
>+++ Eclipse UI/org/eclipse/ui/internal/PerspectiveHelper.java	8 Aug 2008 02:07:19 -0000
>@@ -1286,6 +1286,17 @@
>     }
> 
>     /**
>+     * Used to explicitly close and remove a DW that's being closed
>+     * but that has no visible views. See bug 234484.
>+     * 
>+     * @param dw The DW to close
>+     */
>+    public void closeDetachedWindow(DetachedWindow dw) {
>+    	dw.getShell().close();
>+        detachedWindowList.remove(dw);
>+    }
>+    
>+    /**
>      * Add a part to the presentation.
>      * 
>      * Note: unlike all other LayoutParts, PartPlaceholders will still point to
>Index: Eclipse UI/org/eclipse/ui/internal/DetachedWindow.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/DetachedWindow.java,v
>retrieving revision 1.52
>diff -u -r1.52 DetachedWindow.java
>--- Eclipse UI/org/eclipse/ui/internal/DetachedWindow.java	27 May 2008 18:23:58 -0000	1.52
>+++ Eclipse UI/org/eclipse/ui/internal/DetachedWindow.java	8 Aug 2008 02:07:18 -0000
>@@ -260,6 +260,12 @@
>             List views = new ArrayList();
>             collectViewPanes(views, getChildren());
>             
>+            // Surgical fix: -explicitly- close and remove
>+            // this DW if it's already empty. See bug 234484.
>+            if (views.size() == 0) {
>+            	page.getActivePerspective().getPresentation().closeDetachedWindow(this);
>+            }
>+            
>             // Save any drty views
>             if (!handleSaves(views)) {
>             	return false;  // User canceled the save

Actions: View | Diff

Attachments on bug 234484: 109488