Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 108741 Details for
Bug 232982
"Save password" checkbox behaves weird
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read
this important communication.
[patch]
Fix v01
patch_232982.txt (text/plain), 4.85 KB, created by
Tomasz Zarna
on 2008-07-30 09:04:32 EDT
(
hide
)
Description:
Fix v01
Filename:
MIME Type:
Creator:
Tomasz Zarna
Created:
2008-07-30 09:04:32 EDT
Size:
4.85 KB
patch
obsolete
>### Eclipse Workspace Patch 1.0 >#P org.eclipse.team.cvs.core >Index: src/org/eclipse/team/internal/ccvs/core/ICVSRepositoryLocation.java >=================================================================== >RCS file: /cvsroot/eclipse/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/ICVSRepositoryLocation.java,v >retrieving revision 1.26 >diff -u -r1.26 ICVSRepositoryLocation.java >--- src/org/eclipse/team/internal/ccvs/core/ICVSRepositoryLocation.java 15 Dec 2005 22:19:54 -0000 1.26 >+++ src/org/eclipse/team/internal/ccvs/core/ICVSRepositoryLocation.java 30 Jul 2008 12:57:48 -0000 >@@ -1,5 +1,5 @@ > /******************************************************************************* >- * Copyright (c) 2000, 2005 IBM Corporation and others. >+ * Copyright (c) 2000, 2008 IBM Corporation and others. > * All rights reserved. This program and the accompanying materials > * are made available under the terms of the Eclipse Public License v1.0 > * which accompanies this distribution, and is available at >@@ -19,10 +19,10 @@ > * the repository location string for use by connection methods > * and the user authenticator. > * >- * It is not intended to implemented by clients. >- * > * @see IUserAuthenticator > * @see IConnectionMethod >+ * >+ * @noimplement It is not intended to implemented by clients. > */ > public interface ICVSRepositoryLocation extends IAdaptable { > >@@ -103,7 +103,7 @@ > public IUserInfo getUserInfo(boolean allowModificationOfUsername); > > /** >- * Flush any cahced user information related to the repository location >+ * Flush any cached user information related to the repository location > */ > public void flushUserInfo(); > >Index: src/org/eclipse/team/internal/ccvs/core/connection/CVSRepositoryLocation.java >=================================================================== >RCS file: /cvsroot/eclipse/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/connection/CVSRepositoryLocation.java,v >retrieving revision 1.107 >diff -u -r1.107 CVSRepositoryLocation.java >--- src/org/eclipse/team/internal/ccvs/core/connection/CVSRepositoryLocation.java 28 May 2008 17:58:40 -0000 1.107 >+++ src/org/eclipse/team/internal/ccvs/core/connection/CVSRepositoryLocation.java 30 Jul 2008 12:57:59 -0000 >@@ -141,7 +141,7 @@ > private boolean previousAuthenticationFailed = false; > > /** >- * Return the preferences node whose child nodes are teh know repositories >+ * Return the preferences node whose child nodes are the know repositories > * @return a preferences node > */ > public static Preferences getParentPreferences() { >@@ -149,7 +149,7 @@ > } > > /** >- * Return a preferences node that contains suitabel defaults for a >+ * Return a preferences node that contains suitable defaults for a > * repository location. > * @return a preferences node > */ >@@ -548,10 +548,11 @@ > > /* > * Dispose of the receiver by clearing any cached authorization information. >- * This method shold only be invoked when the corresponding adapter is shut >+ * This method should only be invoked when the corresponding adapter is shut > * down or a connection is being validated. > */ > public void dispose() { >+ removeNode(); > flushCache(); > try { > if (hasPreferences()) { >@@ -577,6 +578,19 @@ > } > } > >+ private void removeNode() { >+ ISecurePreferences node = getCVSNode(); >+ if (node == null) >+ return; >+ try { >+// node.removeNode(); >+ node.clear(); >+ } catch (IllegalStateException e) { >+ CVSProviderPlugin.log(IStatus.ERROR, e.getMessage(), e); >+ } >+ >+ } >+ > /* > * @see ICVSRepositoryLocation#getHost() > */ >@@ -889,8 +903,8 @@ > } > > /* >- * The connection was sucessfully made. Update the cached >- * repository location if it is a differnet instance than >+ * The connection was successfully made. Update the cached >+ * repository location if it is a different instance than > * this location. > */ > private void updateCachedLocation() { >@@ -963,6 +977,9 @@ > // We set the password here but it will be cleared > // if the user info is cached using updateCache() > this.password = password; >+ // The password has been changed, reset the flag, so we won't >+ // prompt before attempting to connect >+ previousAuthenticationFailed = false; > } > > /* >@@ -980,10 +997,13 @@ > > public void setAllowCaching(boolean value) { > allowCaching = value; >- if (allowCaching) >+ if (allowCaching) { > updateCache(); >- else >- flushCache(); >+ } else { >+ if (password == null) >+ password = retrievePassword(); >+ removeNode(); >+ } > } > > public void updateCache() { >@@ -1082,7 +1102,7 @@ > * @see ICVSRepositoryLocation#flushUserInfo() > */ > public void flushUserInfo() { >- flushCache(); >+ removeNode(); > } > > /*
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 232982
: 108741 |
108742
|
109050