Attachment 108505 Details for Bug 237556 – public GDB now supports non-stop

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] public GDB now supports non-stop

zpatch.txt (text/plain), 3.60 KB, created by Marc Khouzam

on 2008-07-27 14:22:00 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Khouzam

Created: 2008-07-27 14:22:00 EDT

Size: 3.60 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.dd.gdb
>Index: src/org/eclipse/dd/gdb/internal/provisional/launching/GdbLaunchDelegate.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.gdb/src/org/eclipse/dd/gdb/internal/provisional/launching/GdbLaunchDelegate.java,v
>retrieving revision 1.18
>diff -u -r1.18 GdbLaunchDelegate.java
>--- src/org/eclipse/dd/gdb/internal/provisional/launching/GdbLaunchDelegate.java	22 Jul 2008 19:19:43 -0000	1.18
>+++ src/org/eclipse/dd/gdb/internal/provisional/launching/GdbLaunchDelegate.java	27 Jul 2008 18:13:05 -0000
>@@ -56,7 +56,8 @@
>     implements ILaunchConfigurationDelegate2
> {
>     public final static String GDB_DEBUG_MODEL_ID = "org.eclipse.dd.gdb"; //$NON-NLS-1$
>-        
>+
>+    private final static String NON_STOP_FIRST_VERSION = "6.8.50"; //$NON-NLS-1$
> 	private boolean isNonStopSession = false;
> 
> 	public void launch( ILaunchConfiguration config, String mode, ILaunch launch, IProgressMonitor monitor ) throws CoreException {
>@@ -107,8 +108,15 @@
>     	
>         monitor.worked( 1 );
> 
>-        launch.setServiceFactory(newServiceFactory(LaunchUtils.getGDBVersion(config)));
>+        String gdbVersion = LaunchUtils.getGDBVersion(config);
>         
>+        // First make sure non-stop is supported, if the user want to use this mode
>+        if (isNonStopSession && !isNonStopSupported(gdbVersion)) {
>+            throw new DebugException(new Status(IStatus.ERROR, GdbPlugin.PLUGIN_ID, DebugException.REQUEST_FAILED, "Non-stop mode is only supported starting with GDB " + NON_STOP_FIRST_VERSION, null)); //$NON-NLS-1$        	
>+        }
>+
>+        launch.setServiceFactory(newServiceFactory(gdbVersion));
>+
>         // Create and invoke the launch sequence to create the debug control and services
>         final ServicesLaunchSequence servicesLaunchSequence = 
>             new ServicesLaunchSequence(launch.getSession(), launch, exePath, sessionType, attach);
>@@ -328,10 +336,16 @@
> 		return false;
> 	}
> 	
>+	private boolean isNonStopSupported(String version) {
>+		if (NON_STOP_FIRST_VERSION.compareTo(version) <= 0) {
>+			return true;
>+		}
>+		return false;
>+	}
>+	
> 	private IDsfDebugServicesFactory newServiceFactory(String version) {
> 
>-		// TODO: Fix version number once non-stop GDB is delivered
>-		if (isNonStopSession && version.startsWith("6.8.50.20080327")) { //$NON-NLS-1$
>+		if (isNonStopSession && isNonStopSupported(version)) {
> 			return new GdbDebugServicesFactoryNS(version);
> 		}
> 
>#P org.eclipse.dd.gdb.ui
>Index: src/org/eclipse/dd/gdb/internal/ui/launching/GdbDebuggerPage.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.gdb.ui/src/org/eclipse/dd/gdb/internal/ui/launching/GdbDebuggerPage.java,v
>retrieving revision 1.2
>diff -u -r1.2 GdbDebuggerPage.java
>--- src/org/eclipse/dd/gdb/internal/ui/launching/GdbDebuggerPage.java	22 Jul 2008 19:19:41 -0000	1.2
>+++ src/org/eclipse/dd/gdb/internal/ui/launching/GdbDebuggerPage.java	27 Jul 2008 18:13:05 -0000
>@@ -264,7 +264,6 @@
> 		// TODO: Find a way to determine if non-stop is supported (i.e. find the GDB version) then grey out the check box if necessary 
> 		// Button fNonStopButton = ControlFactory.createCheckBox(subComp, LaunchUIMessages.getString( "GDBDebuggerPage.15") ); //$NON-NLS-1$
> 		fNonStopCheckBox = ControlFactory.createCheckBox(subComp, LaunchUIMessages.getString("GDBDebuggerPage.13")); //$NON-NLS-1$
>-		fNonStopCheckBox.setEnabled(false);
> 		fNonStopCheckBox.addSelectionListener( new SelectionAdapter() {
> 				@Override
> 				public void widgetSelected(SelectionEvent e) {

Flags:

cdtdoug: iplog-

Actions: View | Diff

Attachments on bug 237556: 107226 | 107235 | 107620 | 107674 | 107792 | 108117 | 108341 | 108373 | 108457 | 108503 | 108505