Attachment 108503 Details for Bug 237556 – Hacked threadId

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Hacked threadId

NonStopMultiThreading.patch (text/plain), 2.81 KB, created by Francois Chouinard

on 2008-07-27 14:01:53 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Francois Chouinard

Created: 2008-07-27 14:01:53 EDT

Size: 2.81 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.dd.mi
>Index: src/org/eclipse/dd/mi/service/command/AbstractMIControl.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.mi/src/org/eclipse/dd/mi/service/command/AbstractMIControl.java,v
>retrieving revision 1.15
>diff -u -r1.15 AbstractMIControl.java
>--- src/org/eclipse/dd/mi/service/command/AbstractMIControl.java	22 Jul 2008 19:19:47 -0000	1.15
>+++ src/org/eclipse/dd/mi/service/command/AbstractMIControl.java	27 Jul 2008 18:00:34 -0000
>@@ -259,7 +259,7 @@
> 				if (runControl != null && execDmc != null && runControl.isSuspended(execDmc)) {
> 			    	// Before the command is sent, Check the Thread Id and send it to 
> 			    	// the queue only if the id has been changed.
>-			    	if (targetThread != -1 && targetThread != fCurrentThreadId) {
>+			    	if (targetThread > 0 && targetThread != fCurrentThreadId) {
> 			    		fCurrentThreadId = targetThread;
> 			    		resetCurrentStackLevel();
> 			    		CommandHandle cmdHandle = new CommandHandle(new MIThreadSelect(execDmc), null);
>Index: src/org/eclipse/dd/mi/service/MIRunControl.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.mi/src/org/eclipse/dd/mi/service/MIRunControl.java,v
>retrieving revision 1.17
>diff -u -r1.17 MIRunControl.java
>--- src/org/eclipse/dd/mi/service/MIRunControl.java	25 Jul 2008 16:15:55 -0000	1.17
>+++ src/org/eclipse/dd/mi/service/MIRunControl.java	27 Jul 2008 18:00:33 -0000
>@@ -284,7 +284,7 @@
> 	private StateChangeReason fStateChangeReason;
> 	private IExecutionDMContext fStateChangeTriggeringContext;
> 	
>-	private static final int DEFAULT_THREAD_ID = 1;
>+	private static final int FAKE_THREAD_ID = 0;
> 
>     public MIRunControl(DsfSession session) {
>         super(session);
>@@ -626,9 +626,11 @@
> 
> 	private IExecutionDMContext[] makeExecutionDMCs(IContainerDMContext containerCtx, MIThreadListIdsInfo info) {
> 		if (info.getThreadIds().length == 0) {
>-			//Main thread always exist even if it is not reported by GDB.
>-			//So create thread-id= 0 when no thread is reported
>-			return new IMIExecutionDMContext[]{new MIExecutionDMC(getSession().getId(), containerCtx, DEFAULT_THREAD_ID)};
>+			// Main thread always exist even if it is not reported by GDB.
>+			// So create thread-id = 0 when no thread is reported.
>+			// This hack is necessary to prevent AbstractMIControl from issuing a thread-select
>+			// because it doesn't work if the application was not compiled with pthread.
>+			return new IMIExecutionDMContext[]{new MIExecutionDMC(getSession().getId(), containerCtx, FAKE_THREAD_ID)};
> 		} else {
> 			IExecutionDMContext[] executionDmcs = new IMIExecutionDMContext[info.getThreadIds().length];
> 			for (int i = 0; i < info.getThreadIds().length; i++) {

Flags:

cdtdoug: iplog-

Actions: View | Diff

Attachments on bug 237556: 107226 | 107235 | 107620 | 107674 | 107792 | 108117 | 108341 | 108373 | 108457 | 108503 | 108505