Attachment 108369 Details for Bug 241985 – First part of fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] First part of fix

zpatch.txt (text/plain), 4.94 KB, created by Marc Khouzam

on 2008-07-24 12:18:37 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Khouzam

Created: 2008-07-24 12:18:37 EDT

Size: 4.94 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.dd.dsf.debug
>Index: src/org/eclipse/dd/dsf/debug/service/AbstractDsfDebugServicesFactory.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.dsf.debug/src/org/eclipse/dd/dsf/debug/service/AbstractDsfDebugServicesFactory.java,v
>retrieving revision 1.2
>diff -u -r1.2 AbstractDsfDebugServicesFactory.java
>--- src/org/eclipse/dd/dsf/debug/service/AbstractDsfDebugServicesFactory.java	3 Jul 2008 19:05:18 -0000	1.2
>+++ src/org/eclipse/dd/dsf/debug/service/AbstractDsfDebugServicesFactory.java	24 Jul 2008 16:17:00 -0000
>@@ -10,46 +10,56 @@
>  *******************************************************************************/
> package org.eclipse.dd.dsf.debug.service;
> 
>+import org.eclipse.dd.dsf.debug.service.command.ICommandControl;
> import org.eclipse.dd.dsf.service.DsfSession;
> 
> public abstract class AbstractDsfDebugServicesFactory implements IDsfDebugServicesFactory {
> 
>     @SuppressWarnings("unchecked")
> 	public <V> V createService(DsfSession session, Class<V> clazz) {
>-        if (IDisassembly.class.isAssignableFrom(clazz)) {
>+       	if (IBreakpoints.class.isAssignableFrom(clazz)) {
>+    		return (V)createBreakpointService(session);
>+       	} else if (ICommandControl.class.isAssignableFrom(clazz)) {
>+        	return (V)createCommandControl(session);
>+        } else if (IDisassembly.class.isAssignableFrom(clazz)) {
> 			return (V)createDisassemblyService(session);
>-		} else if (IRegisters.class.isAssignableFrom(clazz)) {
>-			return (V)createRegistersService(session);
>-		} else if (IBreakpoints.class.isAssignableFrom(clazz)) {
>-			return (V)createBreakpointService(session);
>-		} else if (ISourceLookup.class.isAssignableFrom(clazz)) {
>-			return (V)createSourceLookupService(session);
> 		} else if (IExpressions.class.isAssignableFrom(clazz)) {
> 			return (V)createExpressionService(session);
>-		} else if (IStack.class.isAssignableFrom(clazz)) {
>-			return (V)createStackService(session);
>-		} else if (IModules.class.isAssignableFrom(clazz)) {
>-			return (V)createModulesService(session);
> 		} else if (IMemory.class.isAssignableFrom(clazz)) {
> 			return (V)createMemoryService(session);
>-		} else if (IRunControl.class.isAssignableFrom(clazz)) {
>-			return (V)createRunControlService(session);
>+		} else if (IModules.class.isAssignableFrom(clazz)) {
>+			return (V)createModulesService(session);
> 		} else if (IProcesses.class.isAssignableFrom(clazz)) {
> 			return (V)createProcessesService(session);
>+		} else if (IRegisters.class.isAssignableFrom(clazz)) {
>+			return (V)createRegistersService(session);
>+		} else if (IRunControl.class.isAssignableFrom(clazz)) {
>+			return (V)createRunControlService(session);
>+		} else if (ISourceLookup.class.isAssignableFrom(clazz)) {
>+			return (V)createSourceLookupService(session);
>+		} else if (ISignals.class.isAssignableFrom(clazz)) {
>+			return (V)createSignalsService(session);
>+		} else if (IStack.class.isAssignableFrom(clazz)) {
>+			return (V)createStackService(session);
>+		} else if (ISymbols.class.isAssignableFrom(clazz)) {
>+			return (V)createSymbolsService(session);
> 		} 
> 		
> 		return null;
> 	}
>-    
>-	protected abstract IDisassembly createDisassemblyService(DsfSession session);
>-	protected abstract IRegisters createRegistersService(DsfSession session);
>-	protected abstract IBreakpoints createBreakpointService(DsfSession session);
>-	protected abstract ISourceLookup createSourceLookupService(DsfSession session);
>-	protected abstract IExpressions createExpressionService(DsfSession session);
>-	protected abstract IStack createStackService(DsfSession session);
>-	protected abstract IModules createModulesService(DsfSession session);
>-	protected abstract IMemory createMemoryService(DsfSession session);
>-	protected abstract IRunControl createRunControlService(DsfSession session);
>-	protected abstract IProcesses createProcessesService(DsfSession session);
>-	
>+
>+	protected IBreakpoints createBreakpointService(DsfSession session) { return null; }
>+	protected ICommandControl createCommandControl(DsfSession session) { return null; }
>+	protected IDisassembly createDisassemblyService(DsfSession session) { return null; }
>+	protected IExpressions createExpressionService(DsfSession session) { return null; }
>+	protected IMemory createMemoryService(DsfSession session) { return null; }
>+	protected IModules createModulesService(DsfSession session) { return null; }
>+	protected IProcesses createProcessesService(DsfSession session) { return null; }
>+	protected IRegisters createRegistersService(DsfSession session) { return null; }
>+	protected IRunControl createRunControlService(DsfSession session) { return null; }
>+	protected ISourceLookup createSourceLookupService(DsfSession session) { return null; }
>+	protected ISignals createSignalsService(DsfSession session) { return null; }	
>+	protected IStack createStackService(DsfSession session) { return null; }	
>+	protected ISymbols createSymbolsService(DsfSession session) { return null; }
>+
> }

Flags:

cdtdoug: iplog-

Actions: View | Diff

Attachments on bug 241985: 108369 | 108506 | 108679 | 108683