Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 107702 Details for
Bug 205817
[Wizards] Finish in Change ASCII/Binary does nothing if comment required
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read
this important communication.
[patch]
Patch
205817_01.txt (text/plain), 2.45 KB, created by
Pawel Pogorzelski
on 2008-07-17 03:58:29 EDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Pawel Pogorzelski
Created:
2008-07-17 03:58:29 EDT
Size:
2.45 KB
patch
obsolete
>### Eclipse Workspace Patch 1.0 >#P org.eclipse.team.cvs.ui >Index: src/org/eclipse/team/internal/ccvs/ui/wizards/ModeWizardSelectionPage.java >=================================================================== >RCS file: /cvsroot/eclipse/org.eclipse.team.cvs.ui/src/org/eclipse/team/internal/ccvs/ui/wizards/ModeWizardSelectionPage.java,v >retrieving revision 1.11 >diff -u -r1.11 ModeWizardSelectionPage.java >--- src/org/eclipse/team/internal/ccvs/ui/wizards/ModeWizardSelectionPage.java 15 Sep 2006 14:45:57 -0000 1.11 >+++ src/org/eclipse/team/internal/ccvs/ui/wizards/ModeWizardSelectionPage.java 17 Jul 2008 07:56:48 -0000 >@@ -21,7 +21,11 @@ > import java.util.Observer; > > import org.eclipse.jface.dialogs.IDialogConstants; >+import org.eclipse.jface.dialogs.MessageDialogWithToggle; >+import org.eclipse.jface.preference.IPreferenceStore; > import org.eclipse.jface.resource.JFaceResources; >+import org.eclipse.jface.util.IPropertyChangeListener; >+import org.eclipse.jface.util.PropertyChangeEvent; > import org.eclipse.jface.viewers.*; > import org.eclipse.jface.wizard.WizardPage; > import org.eclipse.osgi.util.NLS; >@@ -793,9 +797,21 @@ > fTable.modelChanged(true); > fTable.selectAll(); > filterBox.setFocus(); >+ setupListeners(); > setControl(mainComposite); >+ validatePage(); > } >- >+ >+ private void setupListeners() { >+ fCommentArea.addPropertyChangeListener(new IPropertyChangeListener() { >+ public void propertyChange(PropertyChangeEvent event) { >+ if (event.getProperty() != null) { >+ validatePage(); >+ } >+ } >+ }); >+ } >+ > protected ModeChangeTable getTable() { > return fTable; > } >@@ -813,4 +829,27 @@ > public String getComment(Shell shell) { > return fCommentArea.getCommentWithPrompt(shell); > } >+ >+ private void validatePage() { >+ final String comment = fCommentArea.getComment(false); >+ if (comment.equals("") && !isAllowEmptyCommitComments()) { //$NON-NLS-1$ >+ setPageComplete(false); // then the page is not complete >+ return; >+ } else { >+ setPageComplete(true); >+ } >+ } >+ >+ private boolean isAllowEmptyCommitComments() { >+ // check whether empty comments are allowed >+ final IPreferenceStore store = CVSUIPlugin.getPlugin() >+ .getPreferenceStore(); >+ final String allowEmptyComment = store >+ .getString(ICVSUIConstants.PREF_ALLOW_EMPTY_COMMIT_COMMENTS); >+ if (allowEmptyComment.equals(MessageDialogWithToggle.NEVER)) { >+ return false; >+ } else { >+ return true; >+ } >+ } > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
pawel.pogorzelski1
:
iplog+
Actions:
View
|
Diff
Attachments on
bug 205817
: 107702