Attachment 105224 Details for Bug 213732 – patch for 3.4.1

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch for 3.4.1

patch213732-3.4.1.txt (text/plain), 2.02 KB, created by Adam Archer

on 2008-06-17 18:46:00 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Adam Archer

Created: 2008-06-17 18:46:00 EDT

Size: 2.02 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.forms
>Index: src/org/eclipse/ui/forms/widgets/FormText.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.forms/src/org/eclipse/ui/forms/widgets/FormText.java,v
>retrieving revision 1.80
>diff -u -r1.80 FormText.java
>--- src/org/eclipse/ui/forms/widgets/FormText.java	14 Apr 2008 20:07:49 -0000	1.80
>+++ src/org/eclipse/ui/forms/widgets/FormText.java	17 Jun 2008 22:24:54 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2007 IBM Corporation and others.
>+ * Copyright (c) 2000, 2008 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -836,13 +836,13 @@
> 				if (next) {
> 					for (int j = i + 1; j < children.length; j++) {
> 						Control nc = children[j];
>-						if (nc.setFocus())
>+						if (doFocusSibling(nc))
> 							return false;
> 					}
> 				} else {
> 					for (int j = i - 1; j >= 0; j--) {
> 						Control pc = children[j];
>-						if (pc.setFocus())
>+						if (doFocusSibling(pc))
> 							return false;
> 					}
> 				}
>@@ -850,6 +850,12 @@
> 		}
> 		return false;
> 	}
>+	
>+	private boolean doFocusSibling(Control control) {
>+		if (!(control instanceof FormText))
>+			return control.setFocus();
>+		return ((FormText) control).setFocusProgramatic();
>+	}
> 
> 	/**
> 	 * Controls whether whitespace inside paragraph and list items is
>@@ -1702,6 +1708,13 @@
> 	 * @see org.eclipse.swt.widgets.Control#setFocus()
> 	 */
> 	public boolean setFocus() {
>+		mouseFocus = true;
>+		boolean result = setFocusProgramatic();
>+		mouseFocus = false;
>+		return result;
>+	}
>+	
>+	boolean setFocusProgramatic() {
> 		FormUtil.setFocusScrollingEnabled(this, false);
> 		boolean result = super.setFocus();
> 		FormUtil.setFocusScrollingEnabled(this, true);

Actions: View | Diff

Attachments on bug 213732: 105224