Attachment 101580 Details for Bug 233183 – patch to InstallAction

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch to InstallAction

bug233183.patch (text/plain), 1.68 KB, created by Susan McCourt

on 2008-05-22 14:21:45 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Susan McCourt

Created: 2008-05-22 14:21:45 EDT

Size: 1.68 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.equinox.p2.ui
>Index: src/org/eclipse/equinox/internal/provisional/p2/ui/actions/InstallAction.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/provisional/p2/ui/actions/InstallAction.java,v
>retrieving revision 1.12
>diff -u -r1.12 InstallAction.java
>--- src/org/eclipse/equinox/internal/provisional/p2/ui/actions/InstallAction.java	15 May 2008 18:03:04 -0000	1.12
>+++ src/org/eclipse/equinox/internal/provisional/p2/ui/actions/InstallAction.java	22 May 2008 18:15:48 -0000
>@@ -11,6 +11,7 @@
> 
> package org.eclipse.equinox.internal.provisional.p2.ui.actions;
> 
>+import java.util.ArrayList;
> import org.eclipse.core.runtime.IProgressMonitor;
> import org.eclipse.core.runtime.MultiStatus;
> import org.eclipse.equinox.internal.p2.ui.PlanStatusHelper;
>@@ -99,7 +100,18 @@
> 	 * @see org.eclipse.equinox.internal.provisional.p2.ui.actions.ProfileModificationAction#isEnabledFor(java.lang.Object[])
> 	 */
> 	protected boolean isEnabledFor(Object[] selectionArray) {
>-		return selectionArray.length > 0;
>+		if (selectionArray.length == 0)
>+			return false;
>+		// We allow non-IU's to be selected at this point, but there
>+		// must be at least one installable unit selected that is
>+		// not a category.  
>+		ArrayList iuList = new ArrayList();
>+		for (int i = 0; i < selectionArray.length; i++) {
>+			IInstallableUnit iu = getIU(selectionArray[i]);
>+			if (iu != null && !ProvisioningUtil.isCategory(iu))
>+				iuList.add(iu);
>+		}
>+		return iuList.size() > 0;
> 	}
> 
> 	protected String getTaskName() {

Actions: View | Diff

Attachments on bug 233183: 101308 | 101580 | 101668