Attachment 101105 Details for Bug 231842 – Patch that fixes the described problem for me, please review.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch that fixes the described problem for me, please review.

org.eclipse.gef_231842.txt (text/plain), 1.31 KB, created by Marco Lehmann-Mörz

on 2008-05-20 13:26:55 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Marco Lehmann-Mörz

Created: 2008-05-20 13:26:55 EDT

Size: 1.31 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.gef
>Index: src/org/eclipse/gef/tools/DelayedDirectEditHelper.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.gef/plugins/org.eclipse.gef/src/org/eclipse/gef/tools/DelayedDirectEditHelper.java,v
>retrieving revision 1.9
>diff -u -r1.9 DelayedDirectEditHelper.java
>--- src/org/eclipse/gef/tools/DelayedDirectEditHelper.java	30 Mar 2005 21:27:03 -0000	1.9
>+++ src/org/eclipse/gef/tools/DelayedDirectEditHelper.java	20 May 2008 17:25:59 -0000
>@@ -99,13 +99,16 @@
>  */
> public void run() {
> 	if (activeHelper == this 
>-		&& part.isActive() 
>-		&& viewer.getControl() != null
>-		&& !viewer.getControl().isDisposed()) {			
>-			viewer.getControl().removeFocusListener(focus);
>-			viewer.getControl().removeMouseListener(mouse);
>-			viewer.getControl().removeKeyListener(key);
>-			part.performRequest(req);
>+			&& part.isActive() 
>+			&& viewer.getControl() != null
>+			&& !viewer.getControl().isDisposed()) {			
>+				part.performRequest(req);
>+	}
>+	if (viewer.getControl() != null
>+			&& !viewer.getControl().isDisposed()) {			
>+				viewer.getControl().removeFocusListener(focus);
>+				viewer.getControl().removeMouseListener(mouse);
>+				viewer.getControl().removeKeyListener(key);
> 	}
> 	activeHelper = null;
> }

Flags:

nyssen: iplog+

Actions: View | Diff

Attachments on bug 231842: 101105