Attachment 100567 Details for Bug 232415 – Quick&Dirty (Temporary) Fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Quick&Dirty (Temporary) Fix

232415.patch (text/plain), 1.99 KB, created by Francois Chouinard

on 2008-05-15 18:22:49 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Francois Chouinard

Created: 2008-05-15 18:22:49 EDT

Size: 1.99 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.dd.mi
>Index: src/org/eclipse/dd/mi/service/MIBreakpointsManager.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.mi/src/org/eclipse/dd/mi/service/MIBreakpointsManager.java,v
>retrieving revision 1.8
>diff -u -r1.8 MIBreakpointsManager.java
>--- src/org/eclipse/dd/mi/service/MIBreakpointsManager.java	13 May 2008 20:54:33 -0000	1.8
>+++ src/org/eclipse/dd/mi/service/MIBreakpointsManager.java	15 May 2008 21:26:23 -0000
>@@ -41,6 +41,7 @@
> import org.eclipse.core.runtime.CoreException;
> import org.eclipse.core.runtime.IProgressMonitor;
> import org.eclipse.core.runtime.IStatus;
>+import org.eclipse.core.runtime.Platform;
> import org.eclipse.core.runtime.Status;
> import org.eclipse.core.runtime.jobs.ISchedulingRule;
> import org.eclipse.core.runtime.jobs.Job;
>@@ -1327,7 +1328,21 @@
>         String hostPath = (String) attributes.get(ICBreakpoint.SOURCE_HANDLE);
> 
>         if (hostPath != null) {
>-            ISourceLookupDMContext srcDmc = DMContexts.getAncestorOfType(dmc, ISourceLookupDMContext.class);
>+
>+        	// For Windows, specifying the full path does not work well with GDB.
>+        	// In that case, we only specify the file name and live with the
>+        	// scalability issues.
>+        	// See bug232415
>+            String os = Platform.getOS();
>+            if (os.startsWith("win")) { //$NON-NLS-1$
>+            	int filenameStartIndex = hostPath.lastIndexOf('\\');
>+            	filenameStartIndex += filenameStartIndex == 0 ? 0 : 1;
>+            	attributes.put(ATTR_DEBUGGER_PATH, hostPath.substring(filenameStartIndex));
>+            	rm.done();
>+            	return;
>+            }
>+            
>+        	ISourceLookupDMContext srcDmc = DMContexts.getAncestorOfType(dmc, ISourceLookupDMContext.class);
>             if (srcDmc != null) {
>                 fSourceLookup.getDebuggerPath(srcDmc, hostPath,
>                     new DataRequestMonitor<String>(getExecutor(), rm) {

Actions: View | Diff

Attachments on bug 232415: 100567 | 101604